Open
Conversation
LuisFSegalla
force-pushed
the
add-adapter-controller
branch
from
d031d89 to
424f0b4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
- Coverage 94.20% 90.65% -3.55%
==========================================
Files 4 5 +1
Lines 69 107 +38
==========================================
+ Hits 65 97 +32
- Misses 4 10 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GDYendell
reviewed
Mar 12, 2026
GDYendell
reviewed
Mar 13, 2026
|
|
||
| async def initialise(self): | ||
| await super().initialise() | ||
| # self.chunks.enable_tracing() |
| [value, 1, 4096], # pyright: ignore[reportArgumentType] | ||
| ) | ||
|
|
||
| self.chunks.add_on_update_callback(callback=set_chunk_fp) |
Contributor
There was a problem hiding this comment.
To add a test for this you could:
-
create a controller XspressFPAdapterController
-
mock super initialise
mocker.patch.object(
FrameProcessorAdapterController,
"initialise",
new_callable=mocker.AsyncMock,
)
- mock get_all_sub_controllers to return a list of, say, 4 odin parameters
{idx}/chunks - mock controller.connection
- manually create controller.chunks (because we aren't calling initialise)
- call controller.initialise to create and add the callback
- do chunks.set
- Check that the connection mock has 4 calls to the correct uri with the correct value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a custom FP adapter controller for Xspress.
TODO: